Merged
Conversation
Member
Author
|
@MarcoRossignoli what do you think? Should we make it more configurable? (verbosity?) and change the naming some more? |
Contributor
|
Looks good...but yep maybe we should add the verbosity(VSTEST_DIAGLOG_VERBOSITY optional and we can fallback to Verbose if TryParse fails) so we can ask to start with Error and after Verbose during the analysis, improving a bit the perf. |
Member
Author
|
Maybe I should only call it VSTEST_DIAG & VSTEST_DIAG_VERBOSITY to keep the same name as the argument? |
Contributor
Yep sorry misread |
Contributor
|
|
nohwnd
commented
Jan 25, 2022
Evangelink
reviewed
Jan 25, 2022
Evangelink
reviewed
Jan 25, 2022
Member
|
@nohwnd I have added some minor comments, feel free to disregard them all. |
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.